Vendor containerd 2.0 #1958
Vendor containerd 2.0 #1958
Conversation
Containerd module has changed version to 2.0, This commit changes all of the contained package imports within hcsshim to use the new imports paths for containerd v2 module. Containerd has also made some changes to the client APIs. There is now a new `client` package in containerd that hosts all of the client related code. Our tests have been updated to use this new package. Signed-off-by: Amit Barve <[email protected]>
ambarve
force-pushed
the
user/ambarve/vndr_ctrd_2
branch
from
7ebe6aa
to
4ef26d7
Compare
|
A bit concerned about this change... Shouldn't we wait till 2.0 is fully released before considering vendoring it in? Are there issues with us updating to 2.x around compatibility with our downstream consumers if they still use 1.x themselves? |
Hi @kevpar , Derek mentioned yesterday that this change would be needed before 2.0 tag is cut (in about a month from now). Beta tag of containerd/2.0 is scheduled to go out before Kubecon on Monday. Also, what do you mean by downstream consumers? |
|
Hey folks. Hope this finds you well. I do have a working fork of hcsshim based off containerd v2 RC3 that we are using right now to test nerdctl w. ctdv2, and wanted to check with you if there is interest here in moving forward on that front. Let me know your thoughts on this at your convenience. Thanks! |
|
@apostasie Maybe you can try submitting a PR and see how it goes? |
@AkihiroSuda @apostasie is there a reason you want to vendor containerd/2.0 into hcsshim right away? |
Because nerdctl vendors hcsshim, and nerdctl v2 is going to vendor containerd v2: |
Containerd module has changed version to 2.0, This commit changes all of the contained package imports within hcsshim to use the new imports paths for containerd v2 module.
Containerd has also made some changes to the client APIs. There is now a new
clientpackage in containerd that hosts all of the client related code. Our tests have been updated to use this new package.